Add support for SSE KMS on S3 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I guess we will need to look into adding test infra for this in our test aws account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Server Side Encryption via KMS on S3, by adding a new option to S3 secret named
kms_key_id, and inject the proper headers to use the provided key identifier when present.CREATE SECRET encrypted ( TYPE S3, PROVIDER CREDENTIAL_CHAIN, CHAIN 'config', REGION 'eu-west-1', KMS_KEY_ID 'arn:aws:kms:region:acct-id:key/key-id', SCOPE 's3://bucket/sub/path' );This was tested against S3 directly, there is no tests against minio, as this seems it requires another piece of software (KES).
This is the same PR as duckdb#14475.